Skip to content

fix: enable embeds viewing without authorization #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
musarosro merged 1 commit into from
Feb 3, 2025
Merged

fix: enable embeds viewing without authorization #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion studio/app/embeds/[embedId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ function EmbedPage({ params }: ProjectPageProps) {
);
}

export default withPageAuthRequired(withUserEnabled(EmbedPage));
export default EmbedPage;
6 changes: 1 addition & 5 deletions studio/features/embeds/queries/getEmbed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@ import { injectRepository } from "@features/db/helpers";
import { toPlain } from "@features/helpers/objects";

export default async function getEmbed(id: number) {
if (!(await canReadProjects())) throw new Error("Unauthorized");

const user = (await getUserToken())!;

const embedRepository = await injectRepository(Embed);

const embed = await embedRepository.findOne({
where: { id, project: { user: { id: user.id } } },
where: { id },
});

if (!embed) throw new Error("Not found");
Expand Down
6 changes: 1 addition & 5 deletions studio/features/embeds/queries/getEmbedFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,10 @@ import { injectRepository } from "@features/db/helpers";
import { listFilesInBucket } from "@features/storage";

export default async function getEnbedFile(id: number) {
if (!(await canReadProjects())) throw new Error("Unauthorized");

const user = (await getUserToken())!;

const embedRepository = await injectRepository(Embed);

const embed = await embedRepository.findOne({
where: { id, project: { user: { id: user.id } } },
where: { id },
});

if (!embed) throw new Error("Not found");
Expand Down