chore: address commit comments for commit 8b01d81 (issue #10423)#10433
chore: address commit comments for commit 8b01d81 (issue #10423)#10433Daniel-1600 wants to merge 1 commit intostdlib-js:developfrom
8b01d81 (issue #10423)#10433Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Resolves #10423.
Description
This pull request:
tabulate-byexamples to use "@stdlib/random/array/discrete-uniform"and "@stdlib/array/take" instead of a manual for loop with "randu" and "floor"}}
Related Issues
This pull request has the following related issues:
8b01d81) #10423}}Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted Claude to understand how the discreteUniform function works under the hood and to clarify its specific use cases. However, all proposed changes in this PR were fully authored manually by myself.
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers