Skip to content

docs: fix stale identifier in math/base/special/expm1rel C comment#12444

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-06-02
Jun 3, 2026
Merged

docs: fix stale identifier in math/base/special/expm1rel C comment#12444
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-06-02

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-06-01 13:24:01 -0700 and 2026-06-02 03:02:00 -0700 (SHA range f7a08b6ce..2013317f8, 11 commits).

Description

This pull request:

  • math/base/special/expm1rel — In 0a659c4, fix a stale copy-paste in lib/node_modules/@stdlib/math/base/special/expm1rel/src/main.c: the half-angle-identity branch comment referenced HUGE_VALUE (the JS-side name) instead of HUGE_THRESHOLD (the constant defined in the C file).

Related Issues

None.

Questions

No.

Other

Reviewed the 11 commits merged to develop in the trailing 24h window for typos, bugs, and style-guide violations.

Validation performed:

  • stdlib JavaScript / TypeScript / README / package.json style guide compliance
  • stdlib C style and macro-suffix compliance, plus JS/C cross-language parity in paired implementations
  • Diff-only objective-bug scan (off-by-one, wrong operator, inverted condition, wrong return)
  • Semantic / logic scan over introduced code (focus: expm1rel half-angle identity, new igamax TS overloads, error-message format strings, See Also cross-link integrity, OVERFLOW_THRESHOLD boundary)

Deliberately excluded (per "high-signal only" filter):

  • Single-agent findings that could not be independently re-verified from the diff
  • Findings whose fix would require touching code outside the 24h diff window (e.g., relocating a pre-existing link definition into a <related-links> sentinel block in random/rayleigh/README.md)
  • Style preferences not anchored to an explicit guideline (e.g., renaming the C constant HUGE_THRESHOLD to match the JS-side HUGE_VALUE — judgment call, paired-file naming parity is not a stated rule)

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated 24-hour follow-up audit of commits merged to develop. The reviewer pipeline used four parallel agents (two style, two bug) over the union diff; findings were filtered to those independently corroborated and verifiable from the diff alone before any edits were applied.


@stdlib-js/reviewers


Generated by Claude Code

The inline range comment in `src/main.c` referenced `HUGE_VALUE`, the
name of the JS-side constant. The C constant is `HUGE_THRESHOLD`.
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jun 2, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/expm1rel $\color{green}198/198$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}198/198$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter marked this pull request as ready for review June 2, 2026 16:00
@Planeshifter Planeshifter requested review from a team and kgryte June 2, 2026 16:00
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 2, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 3, 2026
@kgryte kgryte merged commit f8a0988 into develop Jun 3, 2026
54 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-06-02 branch June 3, 2026 01:52
@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants