bench: propagate recent fixes to array/bool and tools/git/scripts - #13951
Draft
Planeshifter wants to merge 2 commits into
Draft
bench: propagate recent fixes to array/bool and tools/git/scripts#13951Planeshifter wants to merge 2 commits into
array/bool and tools/git/scripts#13951Planeshifter wants to merge 2 commits into
Conversation
Propagates fix from cf6c136 ("test: update import") to the sibling `array/bool` benchmark which still imported the permissive `is-boolean` utility while asserting a primitive boolean return value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QgequPdX81fkqyxWXaLB6
Propagates fix from e7c2c09 ("build: replace `uniq` with `sort -u` to deduplicate directories in CI workflows") to `tools/git/scripts` relying on the same adjacency assumption. `uniq` only collapses adjacent duplicate lines, and `git log` author dates are not monotonic, so daily totals were fragmented across multiple count rows. Only order-insensitive consumers (`median.awk`, `mode.awk`, `tabulate.awk`) are affected by the inserted `sort`; scripts whose row ordering is user-visible were left unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QgequPdX81fkqyxWXaLB6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating fixes merged to
developbetween 2026-08-04 and 2026-08-05 (window endingb9396e354) to sibling packages.Description
This pull request:
array/boolbenchmark using the permissiveis-booleanimportuniqwithsort -uto deduplicate directories in CI workflows") totools/git/scriptsrelying on the same adjacency assumptioncf6c136 →
array/boolbenchmarkcf6c136 ("test: update import") swapped the permissive
@stdlib/assert/is-booleanimport for.isPrimitiveinarray/bool'stest.entries.js, since the bare export accepts boxedBooleanobjects while the assertion targets a primitive value. The same defect was the last holdout inarray/bool/benchmark:benchmark.get.jsstill imported the bareis-booleancheck againstBooleanArray#get's primitive return, while every other benchmark in the directory already used.isPrimitive. Applied the identical one-line import fix.Target:
@stdlib/array/bool(benchmark/benchmark.get.js)e7c2c09 →
tools/git/scriptsuniqonly collapses adjacent duplicate lines, and e7c2c09 fixed this in.github/workflows by sorting before deduplicating; the same assumption holds latently intools/git/scripts, wheregit logauthor dates are non-monotonic and fragment daily totals across multipleuniq -crows (5 distinct days yielded 11 rows on this repo's history).sortis inserted beforeuniq -cin the scripts whose consumers are order-insensitive, and the pipeline comments are updated accordingly.Targets:
tools/git/scripts/median_commits_per_daytools/git/scripts/mode_commits_per_daytools/git/scripts/tabulate_total_commits_per_daymerges_per_dayandmerged_pull_requests_per_dayare deliberately excluded: their per-day rows are user-visible output in chronological order (viagit log --reverse), and a plainsortwould reorder them lexicographically.Related Issues
This pull request does not have any related issues.
Questions
No.
Other
Validation. All fix commits merged to
developin the 24-hour window were pattern-specified and searched repo-wide. Each candidate site was reviewed by two independent validation passes (defect confirmation with full-file reads), an adaptation pass, and a style-consistency pass against sibling conventions; only sites unanimously confirmed were included.Deliberately excluded:
merges_per_day/merged_pull_requests_per_day(both validation passes rejected: the fix would reorder user-visible chronological output)constants/**sites missing// asm type annotation(from 46e0a1a: all conflict with a trailing// eslint-disable-line id-lengthpragma; the repo has no convention for combining the two comments — maintainer decision required)math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352 — not defect fixes)The remaining defect classes from the window's fix commits (075cabd description typos, 3d19e26 missing
.jsrequire extensions) have zero remaining sites repo-wide; those source commits fixed the last stragglers.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running an automated fix-propagation routine: candidate sites were located by pattern search and each proposed patch was independently validated by multiple review passes before inclusion.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_019QgequPdX81fkqyxWXaLB6
Generated by Claude Code