Skip to content

test: migrate math/base/special/asecf to ULP-based testing - #14062

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-math-base-special-asecf-ulp
Aug 8, 2026
Merged

test: migrate math/base/special/asecf to ULP-based testing#14062
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-math-base-special-asecf-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for math/base/special/asecf from computed relative tolerance (EPS-scaled delta <= tol) checks to ULP-based assertions;
  • replaces the @stdlib/constants/float32/eps and @stdlib/math/base/special/abs requires with @stdlib/number/float32/base/assert/is-almost-same-value.
  • both test/test.js and test/test.native.js are modified to use the new ULP assertions.

ULP bounds (one per fixture set, each tightened to the measured minimum):

fixture set previous tolerance ULP bound
medium_negative 2.0 * EPS 3
medium_positive 68.0 * EPS 97
large_positive 1.0 * EPS 1
large_negative 1.0 * EPS 1
larger_positive 1.0 * EPS 0
larger_negative 1.0 * EPS 1
huge_negative 1.0 * EPS 0
huge_positive 1.0 * EPS 0

Each bound is the smallest non-negative integer for which every fixture in the corresponding set passes. Starting from a high bound and lowering, the suite passes at the values above (4013/4013 assertions), and decrementing each of the five non-zero bounds by one produces exactly five failures - one per set ; confirming that no bound can be tightened further. The larger_positive, huge_negative, and huge_positive sets match the reference values exactly, hence a bound of 0.

The suite was run twice at the final bounds with identical results, so the bounds are not sensitive to FMA/contraction differences on this machine.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team August 8, 2026 15:26
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 8, 2026
@ujjwalv01 ujjwalv01 changed the title test: migrate math/base/special/asecf to ULP-based testing test: migrate math/base/special/asecf to ULP-based testing Aug 8, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/asecf $\\color{green}160/160$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}160/160$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 8, 2026
@kgryte
kgryte merged commit 059674b into stdlib-js:develop Aug 8, 2026
84 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 8, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants