Skip to content

test: migrate stats/strided/dsem to ULP-based assertions - #14078

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-stats-strided-dsem
Aug 8, 2026
Merged

test: migrate stats/strided/dsem to ULP-based assertions#14078
kgryte merged 1 commit into
developfrom
philipp/ulp-stats-strided-dsem

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for stats/strided/dsem from relative-tolerance-based floating-point comparisons to ULP-based comparisons using @stdlib/assert/is-almost-same-value, per the migration described in [RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue) #11352.
  • replaces the delta/tol tolerance computation (delta = abs( v - expected ); tol = 1.0 * EPS * abs( expected ); t.strictEqual( delta <= tol, true, ... )) in test/test.dsem.js, test/test.dsem.native.js, test/test.ndarray.js, and test/test.ndarray.native.js with t.strictEqual( isAlmostSameValue( v, expected, 1 ), true, 'returns expected value' ).
  • the minimum ULP tolerance required for all assertions to pass was determined empirically to be 1 ULP (0 ULP fails for both the population and sample standard-error-of-the-mean assertions). The full test suite was run twice at this value to confirm deterministic results.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, run as an automated scheduled task against issue #11352: it searched the codebase for a qualifying package with relative-tolerance tests, converted the four test files to use isAlmostSameValue, and determined the minimum passing ULP value (1) empirically by running the test suite at decreasing values.


@stdlib-js/reviewers


Generated by Claude Code

Resolves a part of #11352

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. and removed Good First PR A pull request resolving a Good First Issue. labels Aug 8, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/strided/dsem $\\color{green}349/349$
$\\color{green}+100.00\\%$
$\\color{green}13/13$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}349/349$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 8, 2026
@kgryte
kgryte marked this pull request as ready for review August 8, 2026 23:25
@kgryte
kgryte requested a review from a team August 8, 2026 23:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 8, 2026
@kgryte
kgryte merged commit 64896d0 into develop Aug 8, 2026
83 checks passed
@kgryte
kgryte deleted the philipp/ulp-stats-strided-dsem branch August 8, 2026 23:27
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed Needs Review A pull request which needs code review. labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants