Skip to content

test: migrate math/base/special/atan2d to ULP-based testing - #14118

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-math-base-special-atan2d-ulp
Aug 10, 2026
Merged

test: migrate math/base/special/atan2d to ULP-based testing#14118
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-math-base-special-atan2d-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for math/base/special/atan2d from computed relative tolerance (EPS-scaled delta <= tol) checks to ULP-based assertions;
  • replaces the @stdlib/math/base/special/abs require with @stdlib/number/float64/base/assert/is-almost-same-value. (The EPS constant is removed as it is no longer required).
  • both test/test.js and test/test.native.js are modified to use the new ULP assertions.

ULP bounds (one per fixture set, each tightened to the measured minimum):

fixture set previous tolerance ULP bound
positive_positive 1.2 * EPS 2
negative_positive 2.3 * EPS 4
negative_negative 2.0 * EPS 2

Each bound is the smallest non-negative integer for which every fixture in the corresponding set passes. Starting from a high bound and lowering, the suite passes at the values above, and decrementing each bound by one produces exactly one failure per set, confirming that no bound can be tightened further.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team August 10, 2026 06:02
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Aug 10, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 10, 2026
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Aug 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/atan2d $\\color{green}192/192$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}192/192$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte merged commit 6858ce4 into stdlib-js:develop Aug 10, 2026
129 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants