Skip to content

test: migrate math/base/special/cceiln to ULP-based assertions - #14128

Merged
kgryte merged 2 commits into
developfrom
philipp/ulp-cceiln
Aug 10, 2026
Merged

test: migrate math/base/special/cceiln to ULP-based assertions#14128
kgryte merged 2 commits into
developfrom
philipp/ulp-cceiln

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates math/base/special/cceiln test cases from relative tolerance testing (EPS * abs(...)) to ULP difference testing using @stdlib/assert/is-almost-same-value.
  • updates both test/test.js and test/test.native.js, which shared the same tolerance-based assertion block (subnormal rounding test case).
  • uses a single named ULP constant (value 1), determined to be the minimum ULP bound that still passes the full fixture set. A tolerance of 0 (exact equality) fails 8 of the added assertions, confirming 1 is the tightest bound.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Measured minimum ULP bound: 1 (verified by lowering from 64; 0 fails, 1 passes deterministically across two consecutive runs of the full suite).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code, run as an unattended scheduled task on my account. It studied issue #11352 and several already-merged conversion commits (e.g. math/base/special/csignum, math/base/special/asindf) to mirror the established idiom, then converted the tolerance-based assertions in this package to isAlmostSameValue calls and empirically determined the minimum passing ULP bound.


@stdlib-js/reviewers


Generated by Claude Code

Resolves a part of #11352

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. labels Aug 10, 2026
@stdlib-bot

stdlib-bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cceiln $\\color{green}188/188$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}188/188$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 10, 2026
@kgryte
kgryte marked this pull request as ready for review August 10, 2026 12:24
@kgryte
kgryte requested a review from a team August 10, 2026 12:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 10, 2026
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/cceiln/test/test.native.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte merged commit f48e910 into develop Aug 10, 2026
12 checks passed
@kgryte
kgryte deleted the philipp/ulp-cceiln branch August 10, 2026 12:29
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants