test: migrate stats/base/dists/signrank/quantile to ULP-based assertions - #14154
Conversation
…tions Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013c335xppMBrVgyhHDbznao
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Description
This pull request:
stats/base/dists/signrank/quantilefrom relative tolerance (EPS/delta/tol) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.factory.jsandtest/test.quantile.js(the only test files in the package which used the tolerance idiom;test/test.jscontains only exact assertions and is unchanged). The package has notest.native.js.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires and the associateddelta/tollocals, while preserving the existingexpected[ i ] !== nullfixture guard and overall test structure.ULP bound:
0in both files.The bound was tightened agentically: assertions were run against the full R fixture set (150 cases per file) and pass at
0ULP, i.e. bit-for-bit equality, which is the tightest bound possible. This is expected here, since the signrank quantile function returns integer-valued rank statistics which are exactly representable. The full package suite (326 assertions) was run twice at the final bound with identical results, confirming no FMA/arch-dependent flakiness.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only test files are changed; no source, docs, or fixtures were touched.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. It mirrored the idiom established in previously merged conversions (e.g. #14129, #14141) and determined the minimum passing ULP bound empirically by running the package test suite.
@stdlib-js/reviewers
Generated by Claude Code