test: migrate stats/base/dists/f/kurtosis to ULP-based assertions - #15390
Closed
Planeshifter wants to merge 1 commit into
Closed
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Replaces the relative tolerance idiom (EPS-scaled delta comparison) in test.js and test.native.js with isAlmostSameValue-based assertions per the ULP difference testing migration. Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7bMWtHvGQrc61GAtPMjET --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/f/kurtosisfrom relative tolerance testing to ULP difference testing, per the migration described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.EPS-scaled delta/tolerance comparison intest/test.jsandtest/test.native.jswithisAlmostSameValue-based assertions.0for bothtest.jsandtest.native.js. This was found by starting at a generous ULP value and iteratively lowering it until reaching the minimum value at which all fixtures still pass (verified deterministic across repeated runs).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, following the exact idiom established by prior merged conversions in the same
stats/base/dists/f/*family (e.g.f/mean,f/skewness,f/stdev). The tests were run locally (including building the native addon) to determine the minimum passing ULP bound.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01N7bMWtHvGQrc61GAtPMjET
Generated by Claude Code