Skip to content

test: migrate stats/base/dists/triangular/median to ULP-based assertions - #15396

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-triangular-median
Sep 22, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-triangular-median

Conversation

@Devansh-18155

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates test assertions for @stdlib/stats/base/dists/triangular/median from checks (delta <= 1.0 * EPS * abs(...)) to ULP based assertions using @stdlib/assert/is-almost-same-value.

Related Issues

Does this pull request have any related issues?

#11352

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used AI to test the migratable ULP assertions and veriffy the ULP bound .


@stdlib-js/reviewers

@Devansh-18155
Devansh-18155 requested a review from a team September 21, 2026 14:08
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 21, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/median $\\color{green}197/197$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}197/197$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title test: migrate triangular/median/test to ULP-based assertions test: migrate stats/base/dists/triangular/median to ULP-based assertions Sep 22, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 22, 2026
@kgryte
kgryte merged commit c9510cd into stdlib-js:develop Sep 22, 2026
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants