test: migrate stats/incr/nanmcv to ULP-based assertions - #15412
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D2sx1F2BHVSaL578CQbn3f --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmcv'stest/test.jsfrom relative-tolerance (EPS-based) floating-point assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.delta/tolcomputations (and the now-unneededabsandEPSrequires) in favor oft.strictEqual( isAlmostSameValue( actual, expected, N ), true, 'returns expected value' ), mirroring the idiom used in previously merged conversions for otherstats/incr/*packages (e.g.,stats/incr/mgmean,stats/incr/mse).0is the smallest possible non-negative integer, so this is by construction the tightest bound. The full suite was run three times at this value with identical (fully passing) results, confirming determinism (no FMA/arch flakiness).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified via:
396/396 assertions pass, run three times to confirm determinism.
eslintrun against the changed file reports no issues. Onlytest/test.jswas changed; there is notest.native.jsfor this package, and nopackage.jsondependency changes were needed since@stdlib/assertis resolved via the monorepo'sNODE_PATH.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code (an autonomous coding agent), which searched for a qualifying candidate package (checking for collisions against existing open/merged ULP-migration PRs), studied prior merged conversions for the same idiom, performed the migration, and empirically determined the minimum ULP bounds described above by running the full test suite and confirming tightness/determinism through repeated runs.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01D2sx1F2BHVSaL578CQbn3f
Generated by Claude Code