feat: add `blas/ext/base/ndarray/dvander` by headlessNode · Pull Request #15420 · stdlib-js/stdlib

headlessNode · 2026-09-22T07:24:28Z

Resolves stdlib-js/metr-issue-tracker#1349.

Description

What is the purpose of this pull request?

This pull request:

add blas/ext/base/ndarray/dvander

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves [RFC]: add blas/ext/base/ndarray/dvander metr-issue-tracker#1349.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

stdlib-bot · 2026-09-22T07:26:45Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ndarray/dvander	$\\color{green}142/142$ $\\color{green}+100.00\\%$	$\\color{green}3/3$ $\\color{green}+100.00\\%$	$\\color{green}1/1$ $\\color{green}+100.00\\%$	$\\color{green}142/142$ $\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

kgryte · 2026-09-22T09:45:39Z

+
+    with decreasing powers along the rows.
+
+    If `M <= 0` or `N <= 0`, the function returns the output ndarray


Where are M and N defined?

kgryte · 2026-09-22T09:47:28Z

+
+	so = getStrides( out, false );
+
+	strided( mode, numelDimension( out, 0 ), numelDimension( out, 1 ), getData( x ), getStride( x, 0 ), getOffset( x ), getData( out ), so[ 0 ], so[ 1 ], getOffset( out ) ); // eslint-disable-line max-len


You are getting more than one dimension, just as you retrieved more than one stride. Use getShape, rather than calling numelDimension twice.

kgryte · 2026-09-22T09:49:38Z

+	t.end();
+});
+
+tape( 'if provided `M` equal to `0`, the function returns the output ndarray unchanged', function test( t ) {


What is M? You cannot simply copy-paste the strided test descriptions. "if provided an empty input ndarray, ..."

kgryte · 2026-09-22T09:50:42Z

+	t.end();
+});
+
+tape( 'if provided `N` equal to `0`, the function returns the output ndarray unchanged', function test( t ) {


"if not provided an output ndarray with at least one column, ..."

kgryte · 2026-09-22T09:52:08Z

+	t.end();
+});
+
+tape( 'the function supports output stride with padding (row-major)', function test( t ) {


What does "output stride with padding" mean? Just say "supports output ndarrays within non-unit strides".

kgryte · 2026-09-22T09:52:16Z

+	t.end();
+});
+
+tape( 'the function supports output stride with padding (column-major)', function test( t ) {


Same comment.

kgryte · 2026-09-22T09:52:45Z

+	t.end();
+});
+
+tape( 'the function handles zero values in the input array (row-major, increasing)', function test( t ) {


Suggested change

tape( 'the function handles zero values in the input array (row-major, increasing)', function test( t ) {

tape( 'the function handles zero values in the input ndarray (row-major, increasing)', function test( t ) {

Be consistent.

kgryte · 2026-09-22T09:54:10Z

+
+```text
+[
+    1   x_0^1   x_0^2   ...   x_0^(N-1)


What does N stand for? You need to define your terminology.

"Let the output ndarray have shape [M, N]. When the mode is positive, ..."

kgryte · 2026-09-22T09:55:14Z

+
+## Notes
+
+-   If `M <= 0` or `N <= 0`, the function returns the output ndarray unchanged.


Same comment. M and N have been simply copy-pasted from the strided docs, but you need to explain them here.

"Let the output ndarray have shape [M, N]. If M <= 0 or ..."

kgryte

Left initial comments.

feat: add blas/ext/base/ndarray/dvander

9fa8a5d

headlessNode requested a review from a team September 22, 2026 07:24

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Sep 22, 2026

headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Sep 22, 2026

kgryte added review: 5 and removed Needs Review A pull request which needs code review. labels Sep 22, 2026

kgryte reviewed Sep 22, 2026

View reviewed changes

kgryte requested changes Sep 22, 2026

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. review: 3 and removed review: 5 labels Sep 22, 2026

This was referenced Sep 22, 2026

feat: add blas/ext/base/ndarray/svander #15419

Open

feat: add blas/ext/base/ndarray/gvander #15401

Open

Navigation Menu

Uh oh!

feat: add `blas/ext/base/ndarray/dvander` - #15420

feat: add `blas/ext/base/ndarray/dvander`#15420
headlessNode wants to merge 1 commit into
stdlib-js:developfrom
headlessNode:blas/nd/dvander

headlessNode commented Sep 22, 2026

Uh oh!

stdlib-bot commented Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte Sep 22, 2026

Uh oh!

kgryte left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		with decreasing powers along the rows.

		If `M <= 0` or `N <= 0`, the function returns the output ndarray


		so = getStrides( out, false );

		strided( mode, numelDimension( out, 0 ), numelDimension( out, 1 ), getData( x ), getStride( x, 0 ), getOffset( x ), getData( out ), so[ 0 ], so[ 1 ], getOffset( out ) ); // eslint-disable-line max-len

	tape( 'the function handles zero values in the input array (row-major, increasing)', function test( t ) {
	tape( 'the function handles zero values in the input ndarray (row-major, increasing)', function test( t ) {


		## Notes

		- If `M <= 0` or `N <= 0`, the function returns the output ndarray unchanged.

Uh oh!

Conversation

headlessNode commented Sep 22, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Sep 22, 2026

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants