Skip to content

Conversation

@Ankit-Trivedi-02
Copy link
Contributor

@Ankit-Trivedi-02 Ankit-Trivedi-02 commented Dec 15, 2025

Resolves #9067.

Description

This pull request fixes a JavaScript/TypeScript linting error caused by the use of an explicit any type in a TypeScript declaration file.

Specifically, this change replaces any with unknown in the type definition for isSignedIntegerDataType, bringing the file into compliance with stdlib linting rules and TypeScript best practices.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

No.

Checklist

  • Read, understood, and followed the contributing guidelines.

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I consulted ChatGPT to understand the linting error and confirm the appropriate TypeScript type replacement. The code change itself was authored manually.

Checklist

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 15, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/assert/is-signed-integer-data-type $\color{green}146/146$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}146/146$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 16, 2025
@kgryte
Copy link
Member

kgryte commented Dec 16, 2025

As the upstream issue was closed as "not planned" (ref: #9067), I'll go ahead and close this PR.

Thank you again for your interest in stdlib. We look forward to your future contributions!

@kgryte kgryte closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linting issue

3 participants