Repository navigation
A unit refusal reads as the model's refusal; the one-column Weave stays inside its width - #73
Merged
Merged
Conversation
…k; the one-column Weave keeps its sections' focus gutter inside it userFacingError upper-cases the error code, so UnsupportedBlockError (the 422 a unit or anatomy read gets on GPT-2, Pythia or Qwen3.5 base) became UNSUPPORTEDBLOCKERROR, whose BLOCK matched the tab-lock pattern. The pattern now skips BLOCK (also BLOCK_SITES_*); SessionLockTimeout still reads as a lock. In the one-column Weave (narrow loom or short window) the weave is the scroller and its sections kept their desktop margin 0 -4px, so the weave's content was 4 px wider than the weave.
…earlier pick beside the searched row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dashboard bugs drowse.ai's e2e found at
5c86520a.Unit refusal read as a tab lock.
userFacingErrorupper-cases the error code, soUnsupportedBlockError(the 422 a unit read, token anatomy or unit activity gets on a model without unit sites: GPT-2, Pythia, Qwen3.5 base, natively and in the browser) becameUNSUPPORTEDBLOCKERROR. ItsBLOCKmatched/LOCK|TAKEOVER|…/, so the Units room and the Token view said "Another Drowse tab is using the local model". The pattern now skipsBLOCK((?<!B)LOCK), which also stopsBLOCK_SITES_*codes reading as a lock.SessionLockTimeoutstill reads as one. There's a regression test inconversation-library.test.mjs, and it fails without the fix.One-column Weave 4 px too wide. When the loom is narrow or the window short,
.weavebecomes the scroller (overflow-y: auto,overflow-xstays hidden). Its sections kept the desktopmargin: 0 -4px, so the content was 4 px wider than the weave, andscrollIntoViewcould shift it sideways. In one column the sections drop the negative margin, and their 4 px focus gutter now sits inside the weave.Checks:
npm run check: svelte-check 0 errors and 0 warnings, ledger ratchet, all script tests.npm run build: the dist is rebuilt and committed.5c86520aboth fail.A search by ID left the old unit in the detail. In the Units room, after a row was chosen, searching a unit's ID listed the match but the detail kept the earlier unit (
selected = sel ?? rows[0], and nothing resetsel). An ID search now chooses its unit, layer and kind, as choosing its row does; a word search keeps the current choice.rooms.test.mjspins it and fails without the fix; drowse.ai's units e2e checks it in the browser.