Support C# contextual async identifiers - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncidentifiersCloses #114
Root cause
The pinned and current Tree-sitter C# grammars misparse valid
asyncexpression identifiers and named-argument names. Upstream tracking issue tree-sitter/tree-sitter-c-sharp#276 remains open, so no verified provider release can be pinned for this case.Validation
python -m unittest discover -s tests -p test_csharp_contextual_keywords.py -v— 1 passedpython -m unittest discover -s tests -p test_pattern_guard_complexity.py -v— 11 passedpython -m unittest tests.test_packaging.InstalledPackageTests.test_installed_syntax_pipeline_loads_parser_dependency -v— 1 passedpython -m unittest discover -s tests— 306 passedcode-guard . --ci— exit 0; REVIEW remains visible and non-blockingpython -m compileall -q src skills research tests— exit 0.agent-tools/code-guard.loc-baseline.jsonabsent and not a symlinkgit diff --check origin/main...HEAD— exit 0Review
Independent read-only review found no material findings at
55c97f4447c40194d7454311ecf8b0dc3e9e55e7and returned PASS.