Preserve results across syntax provider failures - #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #115
Contract
Incomplete runs use
overall: incomplete, retain the completed aggregate separately, preserve authoritative findings, and mark only affected syntax guards incomplete. Successful output keeps its existing schema and bytes.--cinever makes unavailable evidence successful.The syntax pipeline continues only for
SyntaxAnalysisErrorandProviderUnavailableError. Arbitrary exceptions, including unexpected concrete-parser exceptions, retain the existing abort boundary.Validation
python -m unittest discover -s tests— 312 passedcode-guard . --ci— exit 0 with visible non-blocking REVIEWpython -m compileall -q src skills research tests— exit 0git diff --check origin/main...HEAD— exit 0Review
Independent review found and blocked overly broad concrete-parser exception wrapping. The remediation narrows translation to
RuntimeError, proves arbitrary exception identity propagation through the real provider boundary, and passed independent re-review at4e7ea2cf176b30b06713e319ce918b1f78e74f58.