feat(calendar): improve parity for recurrence, availability, and selection#319
Open
salmonumbrella wants to merge 11 commits intosteipete:mainfrom
Open
feat(calendar): improve parity for recurrence, availability, and selection#319salmonumbrella wants to merge 11 commits intosteipete:mainfrom
salmonumbrella wants to merge 11 commits intosteipete:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests verifying --plain overrides GOG_FORCE_OUTPUT and --non-interactive auto-JSON. Add comment explaining why TTY-positive path cannot be tested (captureStdout uses os.Pipe, always non-TTY). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rewrite if-else chain to switch statement (gocritic) - Rename `clear` to `clearAll` to avoid shadowing builtin (predeclared) - Remove unused `primaryURL` helper (unused) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deduplicate --all calendar resolution and input collection between freebusy and conflicts commands into resolveAllCalendarIDs and collectCalendarInputs helpers in calendar_selection.go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace 4-value positional return (targetEventID, parentEventID, parentRecurrence, error) with a named struct for clarity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-recurring paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…alendarInputs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cal,--calendars, and--allflags tofreebusyandconflictscommands for calendar selection by name/index--scope singleand--scope futurenow work when given an instance event ID instead of the master)day_of_week/dayOfWeektocalendar timeJSON and text outputGOG_FORCE_OUTPUTenv alias and--non-interactiveauto-JSON when stdout is non-TTYprimaryURLscopeResultstruct (code review follow-up)Test plan
go test ./... -count=1)resolveRecurringSeriesID(master, instance, non-recurring)dedupeCalendarTargetsandcollectCalendarInputs--plainoverridingGOG_FORCE_OUTPUTand--non-interactive--allgo vet ./...cleango build ./...clean🤖 Generated with Claude Code