fix(contacts): correct parameter types in contacts apply helpers#355
Open
laihenyi wants to merge 2 commits intosteipete:mainfrom
Open
fix(contacts): correct parameter types in contacts apply helpers#355laihenyi wants to merge 2 commits intosteipete:mainfrom
laihenyi wants to merge 2 commits intosteipete:mainfrom
Conversation
Go's parameter grouping syntax caused `given` and `org` to be typed as `bool` instead of `string` in contactsApplyPersonName and contactsApplyPersonOrganization, resulting in a build failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rewrite if-else chain to switch statement (gocritic) - Rename `clear` variable to `clearAll` to avoid shadowing predeclared identifier (predeclared) - Remove unused `primaryURL` function (unused) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contactsApplyPersonNameandcontactsApplyPersonOrganizationwhere Go's parameter grouping syntax causedgivenandorgto be typed asboolinstead ofstringgivenSet bool, given, familySet boolgroupsgivenandfamilySetasbool, butgivenshould bestringTest plan
makebuilds successfullymake testall tests pass🤖 Generated with Claude Code