fix: prevent SVG NFTs from collapsing to 0x0#2746
Open
AdamBuzzard wants to merge 2 commits intostellar:masterfrom
Open
fix: prevent SVG NFTs from collapsing to 0x0#2746AdamBuzzard wants to merge 2 commits intostellar:masterfrom
AdamBuzzard wants to merge 2 commits intostellar:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CollectibleInfo image container styling to prevent SVG-based NFT images (notably those using width="100%" / height="100%") from collapsing to a 0x0 rendered size in the popup UI.
Changes:
- Add
width: 100%to.CollectibleInfo__imageto ensure the container has a definite inline size. - Add
aspect-ratio: 1 / 1to.CollectibleInfo__imageso the container maintains a square height derived from its width, avoiding collapse when child SVG dimensions are percentage-based.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where valid SVG NFTs (e.g. SEP-50 standard tokens) with
width='100%'andheight='100%'collapse to a 0x0 height inside theCollectibleInfo__imagecontainer. By adding an explicitaspect-ratio: 1 / 1;, it ensures that the container maintains correct square proportions and standard SVGs render visibly.Changes
aspect-ratio: 1 / 1andwidth: 100%to.CollectibleInfo__imageinstyles.scss.