Fix Windows build failing on dead code errors - #2737
Merged
Merged
Conversation
leighmcculloch
requested review from
a team
and
a balanced review from Copilot
September 21, 2026 09:20
leighmcculloch
changed the title
leighmcculloch
enabled auto-merge (squash)
September 21, 2026 09:21
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The platform gates consistently cover the Unix-only implementation, callers, and tests without changing Unix behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Restricts Unix-specific permission-hardening code and test imports to Unix builds, resolving Windows compilation failures.
Changes:
- Gates
FileModeandenforce_hardened_treebehind#[cfg(unix)]. - Gates the corresponding test import on Unix.
| File | Description |
|---|---|
cmd/soroban-cli/src/config/locator.rs |
Makes permission-tree hardening Unix-only. |
cmd/soroban-cli/src/commands/contract/build/source_archive.rs |
Prevents unused imports in Windows tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fnando
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Put
FileModeandenforce_hardened_treein the config locator fully behind#[cfg(unix)].Why
The Rust workflow's Windows jobs (
build-and-test-windows,publish-dry-run) have been failing becauseFileModeandenforce_hardened_treeare only ever called from unix-only sites and tests and become dead code on windows.For example:
Since the items are only needed on unix builds, they can be cfg behind the unix property so that the dead code doesn't exist for Windows builds.
Known limitations
N/A