💻 Convert low-res Soroban fee diagram to Mermaid#2407
Draft
JFWooten4 wants to merge 10 commits intostellar:mainfrom
Draft
💻 Convert low-res Soroban fee diagram to Mermaid#2407JFWooten4 wants to merge 10 commits intostellar:mainfrom
JFWooten4 wants to merge 10 commits intostellar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing diagram isn't bad per se, but it is noticeably underscaled when expanding to wide viewframes. The text just gets huge inside the ref while the page looks minuscule by comparison. And going forward, it's a lot easier for anyone to update a code diagram than recreate the entire image.