Support a fixed local port for the OIDC login redirect - #92
Open
karcaw wants to merge 2 commits into
Open
Conversation
Adds a local_server_port config key. When set, doLogin() binds that exact port instead of a random free one, and fails with a clear error if it's unavailable. Needed when an OIDC client registration only allows a specific redirect_uri (e.g. http://127.0.0.1:PORT) rather than any ephemeral port. Leaving it unset keeps the existing random-port behavior.
Adds an interactive setup wizard prompt for local_server_port, so it can be configured through `aws-cli-oidc setup` instead of only by hand-editing config.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
local_server_portconfig key, settable viaconfig.yamlor theaws-cli-oidc setupwizard. When set,doLogin()binds that exact portinstead of a random free one, and fails with a clear error if it's
unavailable. Needed when an OIDC client registration only allows a specific
redirect_urirather than any ephemeral port. Leaving it unset keeps theexisting random-port behavior.