Added support of toolchains for rustfmt#671
Open
mikebohdan wants to merge 1 commit intostevearc:masterfrom
Open
Added support of toolchains for rustfmt#671mikebohdan wants to merge 1 commit intostevearc:masterfrom
mikebohdan wants to merge 1 commit intostevearc:masterfrom
Conversation
stevearc
requested changes
Mar 19, 2025
| options = { | ||
| -- The default edition of Rust to use when no Cargo.toml file is found | ||
| default_edition = "2021", | ||
| default_toolchain = "stable", |
Owner
There was a problem hiding this comment.
The default_edition is only a default because it's what we use if there is no Cargo.toml file. Let's rename this to just toolchain.
Owner
There was a problem hiding this comment.
And should add a short comment above to explain it as well
| }, | ||
| args = function(self, ctx) | ||
| local args = { "--emit=stdout" } | ||
| local toolchain = "+" .. self.options.default_toolchain |
Owner
There was a problem hiding this comment.
Can you link me to the documentation for passing +<toolchain> to rustfmt? I've seen this for cargo, but would like to read something about how it works for rustfmt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the ability to pick a toolchain for rustfmt. This will allow nightly formatting rules while using a non-nightly toolchain.