Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 109 110 +1
Lines 2643 2669 +26
Branches 331 332 +1
=======================================
+ Hits 2638 2664 +26
Misses 4 4
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmatthews20
previously approved these changes
Mar 16, 2026
DavidFair
reviewed
Mar 17, 2026
Not all the OpenStack commands require the same units for size. Some of them expect Gigabytes while other work with Megabytes. Also, there is no guarantee that the forms for stackstorm automation will always ask for the right units. In particular if some of them change in the future, and our forms and automation are not up to date. This class may help with those situations. Objects can be instantiated with whatever value and unit is passed via the forms, but the workflows can then request the units actually needed for each command.
jose-caballero
force-pushed
the
class_for_unit_conversion
branch
from
dccaa0b to
334d911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?