Avoids to write the tmpPath if it is already in place.#168
Open
hmadrigal wants to merge 1 commit intostirno:devfrom
hmadrigal:dev
Open
Avoids to write the tmpPath if it is already in place.#168hmadrigal wants to merge 1 commit intostirno:devfrom hmadrigal:dev
hmadrigal wants to merge 1 commit intostirno:devfrom
hmadrigal:dev
Conversation
hmadrigal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tmp file may be readonly in multhreading context, (e.g. running different test on different threads/processes).
While multiple tests are being executed, the tmpPath file already exists and it is readonly (locked by other threads/processes). The code change does not tries to overwrite the file if it already exists and have the same length