Repository navigation
#263 feat: Enhance project.json support for Manifest.PrivateData - #264
Merged
stiwicourage merged 2 commits intoOct 7, 2026
Merged
stiwicourage merged 2 commits into
stiwicourage merged 2 commits into
Conversation
- Added support for `Manifest.PrivateData` in `project.json` to allow arbitrary consumer-defined metadata. - Updated `BuildManifest` to serialize structured `PrivateData` into the generated `.psd1`, preserving nested objects and types. - Implemented validation to reject collisions with reserved `PSData` keys in `PrivateData`. - Created utility functions for converting data to PowerShell literals and updating manifest private data. - Added comprehensive tests for `ConvertTo-PowerShellDataLiteral` and `Update-ManifestPrivateData` to ensure correct functionality. - Updated documentation to reflect changes in `project.json` schema and usage of `PrivateData`.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Code Coverage Gates Passed
Overall Coverage: 99.8%
(required = 95%)
New & Changed Code Coverage: 100%
(required = 99%)
Review details by gate
-
Overall Coverage
- Pass/Fail Reason:
The overall coverage gate was checked for all code and meets the goal: 99.8% covered >= threshold = 95% - Action:
You have 296 files with a sum of 4299 covered and 7 uncovered lines of code.
- Pass/Fail Reason:
-
New & Changed Code Coverage
- Pass/Fail Reason:
New or changed code meets coverage goal: 100% covered >= threshold = 99% - Action:
You modified 3 files, and covered 150 added/modified lines of code.
- Pass/Fail Reason:
16 of 37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifest.PrivateDatafeature already staged in this branch.3.3.2-previewis still the right SemVer target: this branch adds new public configuration capability without a breaking change, so the next stable line would be a minor release while the active develop-style working version stays on the preview suffix.CHANGELOG.mdandRELEASE_NOTE.mdalready describe the final intended behavior clearly enough, so no further release-file edits were required in this pass.Affected area
novaCLI or command routingproject.jsonhandlingREADME.md,CONTRIBUTING.md, repository workflow docs)docs/*.html)docs/NovaModuleTools/en-US/*.md)src/resources/example/project.json, workflow dependencies, release tooling)Review guidance
src/private/build/BuildManifest.ps1,src/private/build/UpdateManifestPrivateData.ps1, andsrc/private/build/ConvertToPowerShellDataLiteral.ps1because that is the release-relevant workflow that turnsproject.jsonconfiguration into the generated manifest.src/private/build/,tests/private/build/,tests/public/TestNovaBuild.Integration.Tests.ps1,src/resources/Schema-Project.json,docs/schema/v3/project.json,docs/project-json-reference.html,CHANGELOG.md, andRELEASE_NOTE.md.PrivateDatamanifests by re-importing the generated.psd1because PowerShell'sTest-ModuleManifestcan reject valid consumer-defined top-levelPrivateData; that limitation is now documented explicitly.Validation
Invoke-NovaBuildInvoke-NovaTestTest-NovaBuild./scripts/build/Invoke-ScriptAnalyzerCI.ps1./scripts/build/ci/Invoke-NovaModuleToolsCI.ps1% nova build,% nova test,% nova merge,% nova deploy,% nova publish,% nova release,% nova update,% nova notification, or% nova initas relevant)Validation notes:
Documentation and release follow-up
README.mdreviewed and updated if contributor workflow, architecture, CI, release, or automation changedCONTRIBUTING.mdreviewed and updated if contribution expectations or review guidance changedCHANGELOG.mdreviewed and updated if the change matters to users, maintainers, or contributorsRELEASE_NOTE.mdreviewed and updated if the change affects public cmdlet usage, CLI usage, configuration semantics, or migration expectationsdocs/NovaModuleTools/en-US/help updated if a public command or CLI behavior changeddocs/*.htmlupdated if end-user workflows or examples changedsrc/resources/example/reviewed and updated if the real-world project layout, package model, or upload workflow changedMaintainability, compatibility, and risk
Risk, rollout, or rollback notes:
Important
Do not use a public pull request to disclose a vulnerability before coordinated handling.
Use the private reporting path in
SECURITY.mdfor new security issues.