Repository navigation
Enhance coverage path resolution and artifact management in Invoke-NovaTest - #267
Merged
Merged
Conversation
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Code Coverage Gates Passed
Overall Coverage: 99.9%
(required = 95%)
New & Changed Code Coverage: 100%
(required = 99%)
Review details by gate
-
Overall Coverage
- Pass/Fail Reason:
The overall coverage gate was checked for all code and meets the goal: 99.9% covered >= threshold = 95% - Action:
You have 296 files with a sum of 4314 covered and 6 uncovered lines of code.
- Pass/Fail Reason:
-
New & Changed Code Coverage
- Pass/Fail Reason:
New or changed code meets coverage goal: 100% covered >= threshold = 99% - Action:
You modified 2 files, and covered 21 added/modified lines of code.
- Pass/Fail Reason:
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/develop(the local branch isdevelopand is ahead oforigin/developby 2 commits). The diff is a patch-level fix forInvoke-NovaTestso coverage discovery, coverage output, and artifact isolation stay rooted in the selected Nova project even afterSet-Locationbetween sibling projects.CHANGELOG.md,RELEASE_NOTE.md, and command-help updates.3.4.1. Currentdevelopprerelease version3.4.1-previewis already correct for this branch.Invoke-NovaTestcould report0%coverage and write coverage artifacts into the wrong sibling project when PowerShell started in one repository and later navigated into another withSet-Location.Closes #123).Invoke-NovaTest.Affected area
novaCLI or command routingproject.jsonhandlingREADME.md,CONTRIBUTING.md, repository workflow docs)docs/*.html)docs/NovaModuleTools/en-US/*.md)src/resources/example/project.json, workflow dependencies, release tooling)Review guidance
src/private/quality/GetNovaTestWorkflowContext.ps1andsrc/private/quality/InvokeNovaTestWorkflow.ps1.src/public/,src/private/cli/,scripts/build/ci/,.github/workflows/,docs/, orsrc/resources/example/).src/private/quality/tests/private/quality/tests/public/InvokeNovaTest.Integration.Tests.ps1docs/NovaModuleTools/en-US/Invoke-NovaTest.mdCHANGELOG.mdRELEASE_NOTE.mdproject.jsonintentionally remains3.4.1-previewondevelop; the next stable release implied by this diff is3.4.1.artifacts/coverage.xmlbyte-identical, so artifact isolation is verified by ensuring the sibling project stays untouched rather than by requiring a changed hash in the selected project.Validation
Invoke-NovaBuildInvoke-NovaTestTest-NovaBuild./scripts/build/Invoke-ScriptAnalyzerCI.ps1./scripts/build/ci/Invoke-NovaModuleToolsCI.ps1% nova build,% nova test,% nova merge,% nova deploy,% nova publish,% nova release,% nova update,% nova notification, or% nova initas relevant)Validation notes:
Documentation and release follow-up
README.mdreviewed and updated if contributor workflow, architecture, CI, release, or automation changedCONTRIBUTING.mdreviewed and updated if contribution expectations or review guidance changedCHANGELOG.mdreviewed and updated if the change matters to users, maintainers, or contributorsRELEASE_NOTE.mdreviewed and updated if the change affects public cmdlet usage, CLI usage, configuration semantics, or migration expectationsdocs/NovaModuleTools/en-US/help updated if a public command or CLI behavior changeddocs/*.htmlupdated if end-user workflows or examples changedsrc/resources/example/reviewed and updated if the real-world project layout, package model, or upload workflow changedMaintainability, compatibility, and risk