Skip to content

misc: Use ansible_facts instead of deprecated top-level fact variables #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vojtechtrefny merged 1 commit into from
Aug 21, 2026
Merged

misc: Use ansible_facts instead of deprecated top-level fact variables #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions misc/libbytesize-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
- libtool
- autoconf
- automake
when: ansible_distribution == 'Fedora'
when: ansible_facts['distribution'] == 'Fedora'

- name: Install dnf-plugins-core for dnf builddep (Fedora)
package: name=dnf-plugins-core state=present
when: ansible_distribution == 'Fedora'
when: ansible_facts['distribution'] == 'Fedora'

- name: Install build dependencies (Fedora)
command: "dnf -y builddep libbytesize --nogpgcheck"
when: ansible_distribution == 'Fedora'
when: ansible_facts['distribution'] == 'Fedora'

- name: Install test dependencies (Fedora)
package:
Expand All @@ -31,7 +31,7 @@
- python3-pocketlint
- python3-pylint
- python3-pycodestyle
when: ansible_distribution == 'Fedora'
when: ansible_facts['distribution'] == 'Fedora'

##### CentOS
- name: Install basic build tools (CentOS)
Expand All @@ -43,29 +43,29 @@
- libtool
- autoconf
- automake
when: ansible_distribution == 'CentOS'
when: ansible_facts['distribution'] == 'CentOS'

- name: Install dnf-plugins-core for dnf builddep (CentOS)
package: name=dnf-plugins-core state=present
when: ansible_distribution == 'CentOS'
when: ansible_facts['distribution'] == 'CentOS'

- name: Install build dependencies (CentOS)
command: "dnf -y builddep libbytesize --nogpgcheck"
when: ansible_distribution == 'CentOS'
when: ansible_facts['distribution'] == 'CentOS'

- name: Install test dependencies (CentOS)
package:
state: present
name:
- glibc-all-langpacks
- python3-pip
when: ansible_distribution == 'CentOS'
when: ansible_facts['distribution'] == 'CentOS'

- name: Install pylint, polib, pycodestyle and pocketlint using pip (CentOS)
pip:
name: ['pylint', 'pycodestyle', 'polib', 'pocketlint']
executable: pip3
when: ansible_distribution == 'CentOS'
when: ansible_facts['distribution'] == 'CentOS'

##### Debian/Ubuntu
- name: Install basic build tools (Debian/Ubuntu)
Expand All @@ -74,22 +74,22 @@
name:
- gcc
- make
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'

- name: Add source repositories (Debian/Ubuntu)
shell: "grep '^deb ' /etc/apt/sources.list | perl -pe 's/deb /deb-src /' >> /etc/apt/sources.list"
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'

- name: Update apt cache (Debian/Ubuntu)
apt:
update_cache: yes
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'

- name: Install build dependencies (Debian/Ubuntu)
apt:
name: libbytesize
state: build-dep
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'

- name: Install test dependencies (Debian/Ubuntu)
package:
Expand All @@ -100,11 +100,11 @@
- python3-pip
- pycodestyle
- pylint
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'

- name: Install pocketlint using pip (Debian/Ubuntu)
pip:
name: ['pocketlint']
executable: pip3
extra_args: --break-system-packages
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'