Repository navigation
Include settings manager explicitly - #25
Merged
Merged
Conversation
storm/api/verification.h no longer pulls in storm/settings headers transitively once the settings reads are removed from libstorm (see stormchecker/storm#1127). Include storm/settings/SettingsManager.h explicitly in main.cpp to keep storm::settings::initializeAll available.
sjunges
force-pushed
the
fix/settings-include
branch
from
October 10, 2026 09:23
37a1ff5 to
2802c14
Compare
sjunges
added a commit
to stormchecker/storm
that referenced
this pull request
Oct 10, 2026
Remove more settings from the storm-main lib. PreferEliminationChecker is ugly but has always been a bit awkward. We can move it to the environment once they have also been refactored. This currently breaks the starter project, but should go through after stormchecker/storm-project-starter-cpp#25 Replaces #1089.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storm/api/verification.h no longer pulls in storm/settings headers transitively once the settings reads are removed from libstorm (see stormchecker/storm#1127). Include storm/settings/SettingsManager.h explicitly in main.cpp to keep storm::settings::initializeAll available.