Fix: rename oauth mountpath#1275
Conversation
…cret-oauth Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…rets-oauth Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16e03d09b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the OAuth broker client credential secret mount path used by the sn-platform and sn-platform-slim Helm charts, aligning the values.yaml examples with the new location. This appears intended to prevent secret mountPath overlap issues (notably when JWT and OAuth are enabled together).
Changes:
- Renamed the OAuth secret mount path from
/mnt/secrets/oauthto/mnt/secrets-oauthin both charts’_helpers.tpl. - Updated the commented
brokerClientAuthenticationParameters.privateKeyexample in both charts’values.yamlto reference/mnt/secrets-oauth.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| charts/sn-platform/values.yaml | Updates the documented OAuth privateKey example path to match the new mount path. |
| charts/sn-platform/templates/_helpers.tpl | Changes OAuth secret mountPath to /mnt/secrets-oauth. |
| charts/sn-platform-slim/values.yaml | Updates the documented OAuth privateKey example path to match the new mount path. |
| charts/sn-platform-slim/templates/_helpers.tpl | Changes OAuth secret mountPath to /mnt/secrets-oauth. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)