feat(dns-bucket): add optional sqlworkspace S3 bucket - #191
Merged
Conversation
This was referenced Aug 20, 2026
maxsxu
approved these changes
Aug 21, 2026
ciiiii
pushed a commit
that referenced
this pull request
Aug 26, 2026
🤖 I have created a release *beep* *boop* --- ## [4.10.0](v4.9.0...v4.10.0) (2026-08-26) ### Features * **dns-bucket:** add optional sqlworkspace S3 bucket ([#191](#191)) ([ae77276](ae77276)) * **rds:** add private PostgreSQL module ([#193](#193)) ([020ae0c](020ae0c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SQL Workspace feature needs its own S3 bucket for storage, provisioned alongside the other per-poolmember buckets (velero, tiered storage, loki) in the
dns-bucketmodule.Modifications
aws_s3_bucket.sqlworkspace, gated on the newenable_sqlworkspacevariable (defaultfalse, so existing environments are unaffected). Created in the target account, named<pm_name>-sqlworkspace-sncby default.sqlworkspace_bucket_nameto override the generated name.sqlworkspace_bucketoutput (empty string when disabled).Account and naming follow the existing customer-account buckets (
<pm_name>-cluster-backup-snc,<pm_name>-tiered-storage-snc) rather than loki. The-sncsuffix is required: the bootstrap policy scopes bucket permissions tos3_bucket_pattern(default*snc*), so the name must match it fors3:CreateBucketto be authorized.Verifying this change
Verified with
terraform fmt -checkandterraform validateinmodules/dns-bucket, and exercised end to end against a test environment.Documentation
doc