feat(rds): add private PostgreSQL module - #193
Merged
Merged
Conversation
maxsxu
approved these changes
Aug 26, 2026
ciiiii
pushed a commit
that referenced
this pull request
Aug 26, 2026
🤖 I have created a release *beep* *boop* --- ## [4.10.0](v4.9.0...v4.10.0) (2026-08-26) ### Features * **dns-bucket:** add optional sqlworkspace S3 bucket ([#191](#191)) ([ae77276](ae77276)) * **rds:** add private PostgreSQL module ([#193](#193)) ([020ae0c](020ae0c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SQL Workspace needs a private PostgreSQL meta store per poolmember. The resources were previously defined inline in the provisioning layer; moving them into a module lets the AWS v1 and v2 paths share one definition.
Modifications
modules/rds: a private PostgreSQL instance in the VPC's private subnets, with its DB subnet group, security group and generated master password.vpc_cidr; the instance is never publicly accessible and storage is encrypted.connectionoutput (host, port, username, password, database) so the caller can write the credential to its own secret store. The module has no Kubernetes provider.backup_retention_perioddefaults to0,skip_final_snapshotis on and deletion protection is off, so teardown cannot be blocked.Notes:
vpc_cidrmust be the cidr actually in use byvpc_id. When the VPC is supplied rather than created, read it with adata "aws_vpc"lookup — a requested cidr produces an ingress rule that does not match and the instance is unreachable.enabledflag; callers gate it withcounton the module block.Verifying this change
terraform validateandterraform fmt -checkpass. Exercised end to end against a test environment: instance create, update and delete, and a workload pod connecting over TLS 1.3.Documentation
docmodules/rds/README.mdgenerated with terraform-docs.