feat: Add additional_tags to CE logic - #155
Open
mitch-hamm wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Let's run toLower() if that tf var is defined on the GCP resource |
There was a problem hiding this comment.
Pull request overview
Adds an additional_tags map attribute to streamnative_cloud_environment, persisting it into a Kubernetes annotation and hydrating it back into Terraform state on read.
Changes:
- Adds optional
additional_tags(map of strings) to the cloud environment resource schema. - Serializes/deserializes
additional_tagsas JSON in thecloud.streamnative.io/environment-parameter-additional_tagsannotation on create/update/read. - Adds provider description text for the new field.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cloud/resource_cloud_environment.go |
Adds schema + create/update/write/read logic to persist additional_tags via a single JSON annotation. |
cloud/provider.go |
Adds the additional_tags field description string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@maxsxu I validated this but looks like something unrelated in the test suite is now failing. Can we merge and then fix the acceptance tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
additional_tagssupport to thestreamnative_cloud_environmentresource.additional_tagsfield (TypeMap of string) on thestreamnative_cloud_environmentresourcecloud.streamnative.io/environment-parameter-additional_tagsExample usage
This produces the annotation:
cloud.streamnative.io/environment-parameter-additional_tags: {"test":"test"}