Skip to content

Potential fix for code scanning alert no. 5: Information exposure through a stack trace #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yostra wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

Potential fix for code scanning alert no. 5: Information exposure through a stack trace #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/sync-engine/src/supabase/edge-functions/sigma-data-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ Deno.serve(async (req) => {
sql = postgres(dbUrl, { max: 1, prepare: false })
} catch (error: unknown) {
const err = error as Error
console.error('Failed to create postgres connection', err)
return jsonResponse(
{
error: 'Failed to create postgres connection',
details: err.message,
stack: err.stack,
},
500
)
Expand Down Expand Up @@ -83,12 +82,11 @@ Deno.serve(async (req) => {
})
} catch (error: unknown) {
const err = error as Error
console.error('Failed to create StripeSync', err)
await sql.end()
return jsonResponse(
{
error: 'Failed to create StripeSync',
details: err.message,
stack: err.stack,
},
500
)
Expand Down Expand Up @@ -308,8 +306,8 @@ Deno.serve(async (req) => {
})
} catch (error: unknown) {
const err = error as Error
console.error('Sigma worker error:', error)
return jsonResponse({ error: err.message, stack: err.stack }, 500)
console.error('Sigma worker error:', err)
return jsonResponse({ error: 'Sigma worker encountered an unexpected error' }, 500)
} finally {
if (sql) await sql.end()
if (stripeSync) await stripeSync.postgresClient.pool.end()
Expand Down
Loading