Skip to content

Update Data component examples#516

Merged
titouanmathis merged 2 commits into
feature/data-scopefrom
feature/data-examples
Jul 17, 2026
Merged

Update Data component examples#516
titouanmathis merged 2 commits into
feature/data-scopefrom
feature/data-examples

Conversation

@titouanmathis

Copy link
Copy Markdown
Contributor

Summary

  • modernize Data component stories with scoped keyed state and virtual bindings
  • demonstrate mirrored DataModel sources and mutation helpers
  • document scoped source lifecycle and fix stale Data API references

Validation

  • npm run test -- -- Data Action/Action.spec.ts
  • npm run lint:types
  • npm run lint:static
  • uncached Prettier check for modified Markdown files

The docs build was intentionally not run locally.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.08%. Comparing base (8dc5c45) to head (c4b501b).
⚠️ Report is 2 commits behind head on feature/data-scope.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/data-scope     #516      +/-   ##
========================================================
+ Coverage                 80.76%   81.08%   +0.32%     
  Complexity                  145      145              
========================================================
  Files                       102      102              
  Lines                      3255     3252       -3     
  Branches                    615      614       -1     
========================================================
+ Hits                       2629     2637       +8     
+ Misses                      548      537      -11     
  Partials                     78       78              
Flag Coverage Δ
unittests 81.08% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ui/Action/ActionEvent.ts 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Code Review

Risk: Low — I did not find blocking defects in the changed code or examples; this is safe to merge.

This MR refreshes the Data component docs and playground stories around scoped keyed state, mirrored DataModel sources, virtual bindings, and mutation helpers. It also changes Action target resolution back to global scope and updates the related docs/tests to match, which is broader than the stated example-focused intent.


Review usage: 400,401 in (350,208 cached) / 7,955 out tokens — $0.3324 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.4 for commit c4b501b.

Previous review runs

Previous run archived 2026-07-17T10:18:03Z

Code Review

Risk: Low — I did not find any concrete defects in this docs-and-examples update; it looks safe to merge.

This MR refreshes the Data component documentation to use scoped keyed state, mirrored DataModel sources, and virtual bindings across the DataBind, DataModel, DataComputed, DataEffect, and DataScope pages. The updated story scripts register the components their new examples rely on, and the example markup aligns with the keyed/scoped behavior described in the API text.


Review usage: 166,489 in (135,680 cached) / 5,665 out tokens — $0.1959 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.4 for commit 4eb7a78.

Action target resolution is global again; scope a target explicitly with
an id or selector. Data component scoping is unchanged.

Co-authored-by: Claude <noreply@anthropic.com>
@titouanmathis
titouanmathis merged commit c4b501b into feature/data-scope Jul 17, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant