Open
Conversation
pauldavisthefirst
pushed a commit
to Ardour/ardour
that referenced
this pull request
Jul 16, 2020
see also stump/libsmf#7 * Fix validity checks of escaped data * Handle non-EOT-terminated tracks. * Fix buffer overflow on tempo change event * Fix memory leaks in case loading fails * Fix a logic errors in extract_escaped_event() * Fix the assertion problem `is_sysex_byte(status)` * Make libsmf more tolerant to malformed MIDI files. (fixes import of files generated by NoteEdit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_sysex_byte(status)which raises when the sysex or escape event tries to use running status. this is non-standard and libsmf does not support it, so I enforced the check, however some files will use it anyway. test case tmm_Kag_Theme.mid.gzsmf_load_from_memory