Fix MG species restart crash - #2849
Conversation
Modify existing axisymmetric compressible species test to add test for MG restart.
|
Thanks! Note that multigrid is currently only implemented for the flow equations, so species and turbulence are running the single grid solver. |
|
also needed for turbulence, I'll pick that up. |
To be honest, I didn't really check convergence in the test regression test that I modified, I was more focused on removing the segfault. In my internal test cases (a Mach 3 nozzle), I only use multi-grid during the flow initialization with uniform species, although I have regularly had good convergence with MG + the SST solver on a variety of cases. |
Proposed Changes
Currently, the species solver crashes when restarting a multi-grid simulation due to mismatched grid levels in two calls in
CSpeciesSolver::LoadRestart. This PR fixes that, and modifies a test to exercise this code path.It'd be great if someone could also double-check whether this code makes sense. Given this bug, I suspect these lines have never been run since they were committed 5 years ago.
Related Work
I'll send an accompanying PR for the new restart file needed for the test case.
PR Checklist
pre-commit run --allto format old commits.