Skip to content

Fix MG species restart crash - #2849

Open
aureliegrebe wants to merge 4 commits into
su2code:developfrom
aureliegrebe:fix_species_mg_restart
Open

Fix MG species restart crash#2849
aureliegrebe wants to merge 4 commits into
su2code:developfrom
aureliegrebe:fix_species_mg_restart

Conversation

@aureliegrebe

Copy link
Copy Markdown

Proposed Changes

Currently, the species solver crashes when restarting a multi-grid simulation due to mismatched grid levels in two calls in CSpeciesSolver::LoadRestart. This PR fixes that, and modifies a test to exercise this code path.

It'd be great if someone could also double-check whether this code makes sense. Given this bug, I suspect these lines have never been run since they were committed 5 years ago.

Related Work

I'll send an accompanying PR for the new restart file needed for the test case.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Modify existing axisymmetric compressible species test to add test
for MG restart.
@bigfooted

Copy link
Copy Markdown
Contributor

Thanks! Note that multigrid is currently only implemented for the flow equations, so species and turbulence are running the single grid solver.
And multigrid is still not doing a very good job in many cases. Did you get good convergence for this testcase? Because the current settings are not very good.

@bigfooted

Copy link
Copy Markdown
Contributor

also needed for turbulence, I'll pick that up.

@aureliegrebe

Copy link
Copy Markdown
Author

Did you get good convergence for this testcase? Because the current settings are not very good.

To be honest, I didn't really check convergence in the test regression test that I modified, I was more focused on removing the segfault. In my internal test cases (a Mach 3 nozzle), I only use multi-grid during the flow initialization with uniform species, although I have regularly had good convergence with MG + the SST solver on a variety of cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants