Skip to content

Fix implicit target-time evaluation - #2857

Draft
bigboateng wants to merge 1 commit into
su2code:developfrom
bigboateng:codex/issue-2353-time-semantics
Draft

Fix implicit target-time evaluation#2857
bigboateng wants to merge 1 commit into
su2code:developfrom
bigboateng:codex/issue-2353-time-semantics

Conversation

@bigboateng

Copy link
Copy Markdown

What changed

  • centralize projection from zero-based time-iteration labels to physical solver time
  • evaluate direct dual-time target states at (TimeIter + 1) * deltaT
  • use the projected time for grid and surface motion, gusts, solver globals, and history output
  • preserve zero-based output/restart labels and existing adjoint and harmonic-balance interpretations
  • add configuration and first-step rigid-motion regression coverage

Why

In implicit dual-time schemes, TimeIter is a zero-based artifact/restart label, while the state being solved represents the end of that physical step. Several consumers reconstructed physical time directly as TimeIter * deltaT, causing the first implicit state to use time zero for time-varying motion and forcing terms.

This separates artifact identity from target-state time without renumbering restart or output files.

Related to #2353.

Validation

  • built SU2_CFD/src/SU2_CFD
  • built UnitTests/test_driver
  • passed [CConfig][time]: 2 test cases, 12 assertions
  • bounded dual-time integration case retained Time_Iter = 0 and flow_00000.vtk while reporting Cur_Time = 0.01

The full SU2 regression matrix and complete adjoint regression suites were not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant