Fix implicit target-time evaluation - #2857
Draft
bigboateng wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
(TimeIter + 1) * deltaTWhy
In implicit dual-time schemes,
TimeIteris a zero-based artifact/restart label, while the state being solved represents the end of that physical step. Several consumers reconstructed physical time directly asTimeIter * deltaT, causing the first implicit state to use time zero for time-varying motion and forcing terms.This separates artifact identity from target-state time without renumbering restart or output files.
Related to #2353.
Validation
SU2_CFD/src/SU2_CFDUnitTests/test_driver[CConfig][time]: 2 test cases, 12 assertionsTime_Iter = 0andflow_00000.vtkwhile reportingCur_Time = 0.01The full SU2 regression matrix and complete adjoint regression suites were not run.