feat(push): mirror rich notification payload fields on send#14
Merged
Conversation
Add the optional sound, badge, channelId, priority, subtitle, imageUrl, tag, collapseId, threadId, ttl, and mutableContent fields to SendPushProps, matching the server zod schema exactly. The request body is forwarded verbatim with no reshaping. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the new server-side rich push payload fields on
push.send(@sublay/node). Adds the optionalsound,badge,channelId,priority,subtitle,imageUrl,tag,collapseId,threadId,ttl, andmutableContentfields toSendPushProps, matching the server zod schema exactly — same names, same types, no aliases. The request body is forwarded verbatim with no reshaping.Pairs with sublay-io/server-hosted#46.
Changes
src/modules/push/send.ts— extendSendPushProps(documented per field, including the iOS NSE / Android channel caveats)__tests__/push.test.ts— assert the rich fields forward verbatimCLAUDE.md— update the push module signatureTesting
npx jest push→ 3 passednpm run buildclean (ESM + CJS + DTS)🤖 Generated with Claude Code