feat: add spaceReputation object to interfaces, helper, and all modules#16
Merged
Conversation
…modules Phase 3 of space-reputation consolidation. Adds the spaceReputation object to both SpaceReputation*Params interfaces (users variant rejects "context"), deprecates the flat props, and adds buildSpaceReputationParams mirroring core's contract. Migrates all 23 reputation-consuming modules across entities, comments, users, spaces, chat, search, and reports so the object is destructured out and only the helper's flat output reaches axios params — closing the bracket-leak / silent-drop no-op. Adds a serialization regression guard covering each forwarding shape. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the space-reputation consolidation (
@sublay/node).What
Adds the
spaceReputationobject to bothSpaceReputation*Paramsinterfaces (users variant rejects"context"), deprecates the flat props, and addsbuildSpaceReputationParamsmirroring core's contract. Migrates all 23 reputation-consuming modules across entities, comments, users, spaces, chat, search, and reports so the object is destructured out and only the helper's flat output reaches axiosparams.Safety
Backward-compatible by construction (wire unchanged, flat props still accepted). Closes the bracket-leak / silent-drop no-op where a nested object handed to axios
paramswould serialize tospaceReputation[spaceId]=…and be silently ignored by the server. A serialization regression guard covers each forwarding shape (silent-drop,params: data, rest-spread).Tests
369 tests green, typecheck clean.
🤖 Generated with Claude Code