Bound RocksDB info log growth in data-hotblocks NET-818#74
Merged
mo4islona merged 1 commit intoJun 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents unbounded RocksDB info log growth for data-hotblocks by configuring log rotation and retention in the shared DatabaseSettings RocksDB options, limiting LOG / LOG.old.* disk usage per DB.
Changes:
- Set
max_log_file_sizeto 10 MiB to force periodic info log rotation. - Set
keep_log_file_numto 10 to cap retained rotated info logs (≈100 MiB total).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mo4islona
force-pushed
the
net-818-bound-rocksdb-info-log-growth-in-data-hotblocks
branch
from
9cb2a90 to
99357e1
Compare
Set max_log_file_size and keep_log_file_num so LOG.old.* files stop accumulating unboundedly on data-hotblocks pods. Configurable via --rocksdb-max-log-file-size and --rocksdb-keep-log-file-num CLI options (defaults: 10 MB, 10 files). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mo4islona
force-pushed
the
net-818-bound-rocksdb-info-log-growth-in-data-hotblocks
branch
from
6c00ec4 to
077b455
Compare
define-null
approved these changes
Jun 10, 2026
mo4islona
deleted the
net-818-bound-rocksdb-info-log-growth-in-data-hotblocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
max_log_file_size(10 MB) andkeep_log_file_num(10) in the RocksDB options used bydata-hotblocks, capping info log (LOG/LOG.old.*) disk usage at ~100 MB per database.Previously these were left at RocksDB defaults (
max_log_file_size = 0— single unboundedLOGfile, plusLOG.old.*rotated on every reopen withkeep_log_file_num = 1000), which let info logs accumulate unboundedly — the incident cleanup removed ~111 GB from db-0 and ~107 GB from db-1.Closes NET-818
🤖 Generated with Claude Code