Reliable clients#199
Merged
Merged
Conversation
denisbsu
reviewed
Mar 12, 2026
denisbsu
reviewed
Mar 12, 2026
denisbsu
approved these changes
Mar 12, 2026
- stop intercepting dial attempts by the stream behaviour - immediately reject stream if a connection can't be established - run lookups in the background to establish connections with all workers
kalabukdima
force-pushed
the
kalabukdima/reliable-clients
branch
from
724e5db to
038dd24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of capturing dial attempts and triggering Kademlia lookups (taking multiple seconds), make the clients (portal, pings collector, etc) keep the connections to the workers always open. This way the substream is either opened quickly or fails to open allowing the portal to pick another worker.
This saves query time and also makes the transport more robust by avoiding spamming extra kademlia lookups under the load.