Skip to content

Net 682 split assignment#205

Open
toschoosqd wants to merge 3 commits into
mainfrom
net-682-split-assignment
Open

Net 682 split assignment#205
toschoosqd wants to merge 3 commits into
mainfrom
net-682-split-assignment

Conversation

@toschoosqd

Copy link
Copy Markdown
Contributor

Description

Linear: NET-682

Adds feature-gated support for split assignment discovery in sqd-assignments.

This introduces the mvcc-chunks feature flag and extends NetworkState with optional worker_assignment and portal_assignment fields when the feature is enabled. The existing assignment field remains unchanged and always present for backward compatibility.

Also formalizes the deprecated NetworkAssignment::url field:

  • marks it with #[deprecated];
  • defaults it during deserialization;
  • omits it during serialization when absent.

Includes JSON compatibility tests covering:

  • legacy NetworkState deserialization;
  • split assignment deserialization under mvcc-chunks;
  • omitted split assignment fields remaining omitted after JSON round trip;
  • deprecated url defaulting to None and being skipped when absent.

Small unrelated formatting/readability cleanup:

  • replaces implicit peer_id.into() dialing with explicit DialOpts::peer_id(peer_id).build().

Validation:

  • cargo fmt --check
  • cargo test -p sqd-assignments
  • cargo test -p sqd-assignments --features mvcc-chunks
  • cargo check -p sqd-network-transport

Note

Reminder before the scheduler PR: update network-scheduler’s sqd-assignments dependency from local path to the relevant sqd-network commit.

@toschoosqd toschoosqd requested a review from define-null June 10, 2026 11:13
@toschoosqd toschoosqd self-assigned this Jun 10, 2026
Comment thread crates/assignments/src/common.rs
Comment thread crates/assignments/src/common.rs

@define-null define-null left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants