Garmin: Add Timezone Offset Information to Extra Info.#100
Open
mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
Open
Garmin: Add Timezone Offset Information to Extra Info.#100mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
Conversation
Add the offset of the reported dive time to UTC as an Extra Info field. Note that the same offset can also be extracted from the `timezone` field that is returned by `dc_parser_get_datetime()`. Signed-off-by: Michael Keller <github@ike.ch>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds timezone offset information to the Extra Info field for Garmin dive computers. The offset value represents the difference between the reported dive time and UTC, displayed in seconds.
Changes:
- Added a new Extra Info field "Time offset from UTC [s]" that displays the validated timezone offset in seconds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikeller
added a commit
to mikeller/subsurface
that referenced
this pull request
Jan 22, 2026
Add an 'Extra Info' field to show the timezone offset in seconds for dive computers that supply this information. Essentially a 'cut out the middleman' for subsurface/libdc#100. Signed-off-by: Michael Keller <github@ike.ch>
7 tasks
mikeller
added a commit
to mikeller/subsurface
that referenced
this pull request
Jan 22, 2026
Add an 'Extra Info' field to show the timezone offset in seconds for dive computers that supply this information. Essentially a 'cut out the middleman' for subsurface/libdc#100. Signed-off-by: Michael Keller <github@ike.ch>
Contributor
|
Hmmm... If this information is already in |
Member
Author
That's what I thought too, which is why I opened subsurface/subsurface#4689 to supersede this. Let's discuss there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the offset of the reported dive time to UTC as an Extra Info field.
Note that the same offset can also be extracted from the
timezonefieldthat is returned by
dc_parser_get_datetime().