Heinrichs Weikamp: Display the Model for OSTC4 / OSTC5.#85
Merged
mikeller merged 2 commits intosubsurface:Subsurface-DS9from Jan 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to display the model information of the dive computer in the Extra Info section.
- Change the return status for scrubber time fields from DATAFORMAT to UNSUPPORTED.
- Add a new case (case 8) to display the model based on the parser's serial number.
src/hw_ostc_parser.c
Outdated
| snprintf(buf, BUFLEN, "%d", parser->last_scrubber_time_minutes); | ||
| break; | ||
| case 8: | ||
| if (parser->model != OSTC4) { |
There was a problem hiding this comment.
Clarify the rationale behind using the parser's serial number to determine the model string after checking that parser->model is OSTC4. Adding a comment to explain the significance of the 1500 threshold will improve code maintainability.
mikeller
force-pushed
the
hw_ostc_4_5_report_model
branch
2 times, most recently
from
aa53022 to
528ec04
Compare
mikeller
force-pushed
the
hw_ostc_4_5_report_model
branch
3 times, most recently
from
4694a0f to
cf3a14d
Compare
Signed-off-by: Michael Keller <github@ike.ch>
Introduce separate models for the OSTC 4 and OSTC 5 dive computers, giving divers information about which model a particular log was downloaded from. Signed-off-by: Michael Keller <github@ike.ch>
mikeller
force-pushed
the
hw_ostc_4_5_report_model
branch
from
cf3a14d to
1fcd927
Compare
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display the actual model of the dive computer in the Extra Info.