✅(types) complete locales type check - #288
Merged
Merged
Conversation
jbpenrath
force-pushed
the
test/locales
branch
2 times, most recently
from
August 4, 2026 08:13
52d1581 to
a44d17e
Compare
We recently added the nl, de and es locales but we did not update the related type checking to ensure no key is missing. The check is made at 2 levels. First TS level only check fr locales as it blocks build. Then the check-locales script raised error once a divergence is found between en and another locale. This job aims to be run on ci as non-blocking for mergred.
Working on check-locale revealed several errors in our translations. Some de, fr, es, nl keys were simply english ones...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently add nl, de and es locales but we did not update the related type checking to ensure no key is missing.