Fix : Redirect to request Uri instead of pathInfo#97
Open
vrcAlbert wants to merge 1 commit intosuncat2000:masterfrom
Open
Fix : Redirect to request Uri instead of pathInfo#97vrcAlbert wants to merge 1 commit intosuncat2000:masterfrom
vrcAlbert wants to merge 1 commit intosuncat2000:masterfrom
Conversation
|
@vrcAlbert : The issue however is that the You may want to remove this line: - Request::normalizeQueryString(http_build_query($queryParams, null, '&'))But still, l.287 is added the switch param, which is not part of the current request. So, I'd suggest to simply concatenate the result of the This fix should also be applied to the |
fix : remove query string from request URI in redirect response
842a70c to
e594d2d
Compare
Author
|
Thanks @ogizanagi for pointing that out ! Concerning Thanks again for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Asking for
http://hostname.dev/app_dev.php/pathredirects tohttp://m.hostname.dev/pathand does not preserveapp_dev.php.Is there any reason for using pathInfo instead of request URI ?
If not, here's the change you could merge.
Thanks in advance for your time and answer.