fix: exclude Arabic diacritics from spam character-density check#16
Open
codectified wants to merge 1 commit into
Open
fix: exclude Arabic diacritics from spam character-density check#16codectified wants to merge 1 commit into
codectified wants to merge 1 commit into
Conversation
…check Unicode combining marks (category Mn) are the harakat — vowel diacritics attached to Arabic letters. c.isalpha() returns False for them, so they were counted as special characters in the density check. A heavily voweled Arabic query like اللَّهُمَّ صَلِّ عَلَى مُحَمَّدٍ has ~52% Mn characters and was wrongly rejected with 400. Among the top 100 queries by search volume, 12 of 30 Arabic queries were being rejected, including لَا إِلَهَ إِلَّا اَللَّهُ (sunnah-com#8, 152k searches) and the Basmala. Fix: add unicodedata.category(c) != 'Mn' guard so combining marks are not counted as punctuation/symbols in the density ratio. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode combining marks (category Mn) are the harakat — vowel diacritics attached to Arabic letters. They are not punctuation, but c.isalpha() returns False for them, so they were counted as special characters.
A heavily voweled Arabic query like اللَّهُمَّ صَلِّ عَلَى مُحَمَّدٍ has ~52% Mn characters and was wrongly rejected with a 400. The Basmala similarly triggered the filter.
Fix: add unicodedata.category(c) != 'Mn' guard so combining marks are not counted as special characters in the density calculation.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com