Repository navigation
Fix SkyCoord transformation and longitude offset in get_bvec - #160
Closed
sumitsaraswat362 wants to merge 4 commits into
Closed
sumitsaraswat362 wants to merge 4 commits into
sumitsaraswat362 wants to merge 4 commits into
Conversation
Author
|
Closing this PR as I am focusing on other contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152
Description
This PR addresses the bug reported in #152 where
FieldLine.b_along_flinewas returning different values for the same magnetogram depending on its rolling offset.Cause:
In
pfss.Output.get_bvec, the inputSkyCoordwas being transformed to the model's coordinate frame, but the result ofcoords.transform_to()was not being assigned back (it returned a copy). Additionally, the longitude passed to the internal interpolation function_brgiwas not properly adjusted for the_lon0offset (like it is handled insidetracing.py).Fix:
SkyCoordin-place.coords.lon - (self._lon0 - 180 * u.deg)shift before generating the cartesian vector and interpolating.SkyCoordso the rotation matrices (which convert the cartesian output back to spherical coordinates) also operate on the correctly shifted longitude.This aligns the behavior of
get_bvecwith the coordinate handling inside thePerformanceTracer, ensuring consistentBvectors regardless of the magnetogram roll.